Merged
Conversation
…GTH and SET_TRUELENGTH
361dd1b to
db850e4
Compare
Collaborator
|
I also relied on ChatGPT for my PR, but I was ambivalent about how openly to proclaim that :) Now to some benchmarks.
100 iterations of reading cps_00097 with bench::mark
1 iteration of reading usa_00128
More detailed output below, but it appears that in addition to being much simpler, the Rf_lengthgets refactor is ever-so-slightly factor than my more complicated refactor. Unfortunately both are slightly slower than the current version of hipread, but probably not enough to bother users. I will merge this PR on Monday and proceed with a release to CRAN, unless you have any further comments @gergness. Thanks for taking a look and offering a simpler solution! hipread from CRANdtburk's ChatGPT-assisted refactorgergness' simpler ChatGPT-assisted refactor |
Contributor
Author
|
Nope, nothing more to add, sounds good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Well I was successfully nerd sniped into seeing if chatGPT could do it, but I didn't do a benchmark, I'll leave that up to you @dtburk